feat: extend wait_for_response to accept list #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
reviewed
Oct 3, 2023
mikejgray
force-pushed
the
feature/wait-for-response-parity
branch
from
0120113 to
0a7cc1d
Compare
|
Not sure why the tests are failing to run, but: ❯ pytest unittests/test_client.py
==================================================================== test session starts ====================================================================
platform darwin -- Python 3.10.9, pytest-7.4.2, pluggy-1.2.0
rootdir: /Users/Mike/Documents/coding/VoiceAssistants/ovos-bus-client
plugins: cov-4.1.0, anyio-3.7.1
collected 29 items
unittests/test_client.py ............................. [100%]
==================================================================== 29 passed in 0.97s ===================================================================== |
Seems like an issue with PyPI or the GHA runner... |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #52 +/- ##
==========================================
+ Coverage 53.58% 54.33% +0.74%
==========================================
Files 14 14
Lines 1073 1084 +11
==========================================
+ Hits 575 589 +14
+ Misses 498 495 -3
☔ View full report in Codecov by Sentry. |
Adds feature parity with called MessageWaiter and allows for cases where the response is not simply "test.message.response"
mikejgray
force-pushed
the
feature/wait-for-response-parity
branch
from
103fda0 to
26a99b5
Compare
mikejgray
force-pushed
the
feature/wait-for-response-parity
branch
from
26a99b5 to
ad0e05b
Compare
JarbasAl
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature parity with called MessageWaiter and allows for cases where the response is not simply "test.message.response"
#hacktoberfest